aj
1d4f64726b
NestReader opened .pep files with FileStream(path, FileMode.Open), which defaults to FileAccess.ReadWrite. The forge deployment bind-mounts /mnt/pep-nest read-only, so every read-only open was rejected with "Read-only file system" (EROFS) even though the code never writes. Pass FileAccess.Read/FileShare.Read explicitly, matching DrawingReader and ZipHelper elsewhere in PepLib.Core. Once that was fixed, a second pre-existing bug surfaced: GetNestDetailsAsync matched DB rows by NestName AND a literal Path comparison built from the container's local mount path. NestHeader.Path stores the original Windows UNC share path (e.g. \REMCOSRV0\pep nest\) from when PepApi ran directly against the network share, so the comparison can never match post-Docker. Match by NestName alone (ordered by most recent), consistent with the fallback lookup already used elsewhere in NestsController.
34 lines
1.1 KiB
C#
34 lines
1.1 KiB
C#
using PepLib.IO;
|
|
using Xunit;
|
|
|
|
namespace PepLib.Core.Tests.IO;
|
|
|
|
public class NestReaderTests
|
|
{
|
|
[Fact]
|
|
public void Read_ReadOnlyFile_DoesNotRequestWriteAccess()
|
|
{
|
|
// Arrange: a file on a read-only mount denies write-access opens (EROFS on Linux,
|
|
// UnauthorizedAccessException on Windows when the read-only attribute is set).
|
|
// NestReader only ever reads nest files, so it must never request FileAccess.Write.
|
|
var path = Path.GetTempFileName();
|
|
try
|
|
{
|
|
File.SetAttributes(path, FileAttributes.ReadOnly);
|
|
|
|
var reader = new NestReader();
|
|
|
|
// Act / Assert: opening must succeed (i.e. not throw because of the read-only
|
|
// attribute). Parsing the empty/invalid content is expected to fail separately.
|
|
var ex = Record.Exception(() => reader.Read(path));
|
|
|
|
Assert.IsNotType<UnauthorizedAccessException>(ex);
|
|
}
|
|
finally
|
|
{
|
|
File.SetAttributes(path, FileAttributes.Normal);
|
|
File.Delete(path);
|
|
}
|
|
}
|
|
}
|