PairEvaluator was cloning the full CNC program (including all internal cutouts) for every candidate. For parts with many holes (e.g. 952), this caused O(n²) overlap checks and thousands of unnecessary polygon tessellations per candidate. Now extracts the perimeter shape once, builds a lightweight drawing from it, and uses that for all Part.CreateAtOrigin calls. Cutouts are irrelevant for best fit — only the outer boundary matters for pairing. 75x speedup on a 952-hole rectangle (30s → 0.4s). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
144 lines
5.2 KiB
C#
144 lines
5.2 KiB
C#
using OpenNest.Converters;
|
|
using OpenNest.Engine.Fill;
|
|
using OpenNest.Geometry;
|
|
using OpenNest.Math;
|
|
using System.Collections.Concurrent;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
|
|
namespace OpenNest.Engine.BestFit
|
|
{
|
|
public class PairEvaluator : IPairEvaluator
|
|
{
|
|
private const double ChordTolerance = 0.01;
|
|
|
|
public List<BestFitResult> EvaluateAll(List<PairCandidate> candidates)
|
|
{
|
|
if (candidates.Count == 0)
|
|
return new List<BestFitResult>();
|
|
|
|
// Build a perimeter-only drawing once — all candidates share the same drawing.
|
|
// This avoids cloning the full program (with all cutouts) for every candidate.
|
|
var perimeterDrawing = CreatePerimeterDrawing(candidates[0].Drawing);
|
|
|
|
var resultBag = new ConcurrentBag<BestFitResult>();
|
|
|
|
Parallel.ForEach(candidates, c =>
|
|
{
|
|
resultBag.Add(Evaluate(c, perimeterDrawing));
|
|
});
|
|
|
|
return resultBag.ToList();
|
|
}
|
|
|
|
public BestFitResult Evaluate(PairCandidate candidate)
|
|
{
|
|
var perimeterDrawing = CreatePerimeterDrawing(candidate.Drawing);
|
|
return Evaluate(candidate, perimeterDrawing);
|
|
}
|
|
|
|
private BestFitResult Evaluate(PairCandidate candidate, Drawing perimeterDrawing)
|
|
{
|
|
var part1 = Part.CreateAtOrigin(perimeterDrawing);
|
|
|
|
var part2 = Part.CreateAtOrigin(perimeterDrawing, candidate.Part2Rotation);
|
|
part2.Location = candidate.Part2Offset;
|
|
part2.UpdateBounds();
|
|
|
|
// Overlap check — perimeter vs perimeter
|
|
var shape1 = GetPerimeterShape(part1);
|
|
var shape2 = GetPerimeterShape(part2);
|
|
var overlaps = shape1 != null && shape2 != null && shape1.Intersects(shape2, out _);
|
|
|
|
// Convex hull vertices from perimeter polygons only
|
|
var allPoints = GetPartVertices(part1);
|
|
allPoints.AddRange(GetPartVertices(part2));
|
|
|
|
// Find optimal bounding rectangle via rotating calipers
|
|
double bestArea, bestWidth, bestHeight, bestRotation;
|
|
List<double> hullAngles = null;
|
|
|
|
if (allPoints.Count >= 3)
|
|
{
|
|
var hull = ConvexHull.Compute(allPoints);
|
|
var result = RotatingCalipers.MinimumBoundingRectangle(hull);
|
|
bestArea = result.Area;
|
|
bestWidth = result.Width;
|
|
bestHeight = result.Height;
|
|
bestRotation = result.Angle;
|
|
hullAngles = RotationAnalysis.GetHullEdgeAngles(hull);
|
|
}
|
|
else
|
|
{
|
|
var combinedBox = ((IEnumerable<IBoundable>)new IBoundable[] { part1, part2 }).GetBoundingBox();
|
|
bestArea = combinedBox.Area();
|
|
bestWidth = combinedBox.Width;
|
|
bestHeight = combinedBox.Length;
|
|
bestRotation = 0;
|
|
hullAngles = new List<double> { 0 };
|
|
}
|
|
|
|
var trueArea = candidate.Drawing.Area * 2;
|
|
|
|
// Normalize to landscape (width >= height) for consistent display.
|
|
if (bestHeight > bestWidth)
|
|
{
|
|
var tmp = bestWidth;
|
|
bestWidth = bestHeight;
|
|
bestHeight = tmp;
|
|
bestRotation += Angle.HalfPI;
|
|
}
|
|
|
|
return new BestFitResult
|
|
{
|
|
Candidate = candidate,
|
|
RotatedArea = bestArea,
|
|
BoundingWidth = bestWidth,
|
|
BoundingHeight = bestHeight,
|
|
OptimalRotation = bestRotation,
|
|
TrueArea = trueArea,
|
|
HullAngles = hullAngles,
|
|
Keep = !overlaps,
|
|
Reason = overlaps ? "Overlap detected" : "Valid"
|
|
};
|
|
}
|
|
|
|
private static Drawing CreatePerimeterDrawing(Drawing source)
|
|
{
|
|
var entities = ConvertProgram.ToGeometry(source.Program)
|
|
.Where(e => e.Layer != SpecialLayers.Rapid).ToList();
|
|
var profile = new ShapeProfile(entities);
|
|
var program = ConvertGeometry.ToProgram(profile.Perimeter);
|
|
return new Drawing(source.Name, program);
|
|
}
|
|
|
|
private static Shape GetPerimeterShape(Part part)
|
|
{
|
|
var entities = ConvertProgram.ToGeometry(part.Program)
|
|
.Where(e => e.Layer != SpecialLayers.Rapid).ToList();
|
|
var shapes = ShapeBuilder.GetShapes(entities);
|
|
if (shapes.Count == 0) return null;
|
|
shapes[0].Offset(part.Location);
|
|
return shapes[0];
|
|
}
|
|
|
|
private static List<Vector> GetPartVertices(Part part)
|
|
{
|
|
var entities = ConvertProgram.ToGeometry(part.Program)
|
|
.Where(e => e.Layer != SpecialLayers.Rapid).ToList();
|
|
var shapes = ShapeBuilder.GetShapes(entities);
|
|
var points = new List<Vector>();
|
|
|
|
foreach (var shape in shapes)
|
|
{
|
|
var polygon = shape.ToPolygonWithTolerance(ChordTolerance);
|
|
polygon.Offset(part.Location);
|
|
points.AddRange(polygon.Vertices);
|
|
}
|
|
|
|
return points;
|
|
}
|
|
}
|
|
}
|