test: add engine and strategy overlap tests, update stripe filler tests

New EngineOverlapTests verifies all engine types produce overlap-free results. New StrategyOverlapTests checks each fill strategy individually. StripeFillerTests updated to verify returned parts are overlap-free rather than just asserting non-empty results. Remove obsolete FitCircle tests from GeometrySimplifierTests (method was removed). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-27 14:13:47 -04:00
parent 740fd79adc
commit fd93cc9db2
4 changed files with 210 additions and 40 deletions
--- a/OpenNest.Tests/EngineOverlapTests.cs
+++ b/OpenNest.Tests/EngineOverlapTests.cs
@@ -0,0 +1,83 @@
+using OpenNest.Converters;
+using OpenNest.Geometry;
+using OpenNest.IO;
+using Xunit.Abstractions;
+
+namespace OpenNest.Tests;
+
+public class EngineOverlapTests
+{
+    private const string DxfPath = @"C:\Users\AJ\Desktop\Templates\4526 A14 PT15.dxf";
+    private readonly ITestOutputHelper _output;
+
+    public EngineOverlapTests(ITestOutputHelper output)
+    {
+        _output = output;
+    }
+
+    private static Drawing ImportDxf()
+    {
+        var importer = new DxfImporter();
+        importer.GetGeometry(DxfPath, out var geometry);
+        var pgm = ConvertGeometry.ToProgram(geometry);
+        return new Drawing("PT15", pgm);
+    }
+
+    [Theory]
+    [InlineData("Default")]
+    [InlineData("Strip")]
+    [InlineData("Vertical Remnant")]
+    [InlineData("Horizontal Remnant")]
+    public void FillPlate_NoOverlaps(string engineName)
+    {
+        var drawing = ImportDxf();
+        var plate = new Plate(60, 120);
+
+        NestEngineRegistry.ActiveEngineName = engineName;
+        var engine = NestEngineRegistry.Create(plate);
+
+        var item = new NestItem { Drawing = drawing };
+        var success = engine.Fill(item);
+
+        _output.WriteLine($"Engine: {engine.Name}, Parts: {plate.Parts.Count}, Utilization: {plate.Utilization():P1}");
+
+        if (engine is DefaultNestEngine defaultEngine)
+        {
+            _output.WriteLine($"Winner phase: {defaultEngine.WinnerPhase}");
+            foreach (var pr in defaultEngine.PhaseResults)
+                _output.WriteLine($"  Phase {pr.Phase}: {pr.PartCount} parts in {pr.TimeMs}ms");
+        }
+
+        // Show rotation distribution
+        var rotGroups = plate.Parts
+            .GroupBy(p => System.Math.Round(OpenNest.Math.Angle.ToDegrees(p.Rotation), 1))
+            .OrderBy(g => g.Key);
+        foreach (var g in rotGroups)
+            _output.WriteLine($"  Rotation {g.Key:F1}°: {g.Count()} parts");
+
+        var hasOverlaps = plate.HasOverlappingParts(out var collisionPoints);
+        _output.WriteLine($"Overlaps: {hasOverlaps} ({collisionPoints.Count} collision pts)");
+
+        if (hasOverlaps)
+        {
+            for (var i = 0; i < System.Math.Min(collisionPoints.Count, 10); i++)
+                _output.WriteLine($"  ({collisionPoints[i].X:F2}, {collisionPoints[i].Y:F2})");
+        }
+
+        Assert.False(hasOverlaps,
+            $"Engine '{engineName}' produced {collisionPoints.Count} collision point(s) with {plate.Parts.Count} parts");
+    }
+
+    [Fact]
+    public void AdjacentParts_ShouldNotOverlap()
+    {
+        var plate = TestHelpers.MakePlate(60, 120,
+            TestHelpers.MakePartAt(0, 0, 10),
+            TestHelpers.MakePartAt(10, 0, 10));
+
+        var hasOverlaps = plate.HasOverlappingParts(out var pts);
+        _output.WriteLine($"Adjacent squares: overlaps={hasOverlaps}, collision count={pts.Count}");
+
+        Assert.False(hasOverlaps, "Adjacent edge-touching parts should not be reported as overlapping");
+    }
+}