fix(post-review): list part-support warnings in the post review

PartSupport findings counted toward the headline and the Post Anyway
checkbox but had no tile or list group, so an operator saw "1 warning"
with nothing to read and was likely to tick through a part that may tip
once cut free. A test now fails if any finding kind is left unlisted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ajandClaude Opus 5.5 committed 2026-11-02 09:51:10 -05:00
1 parent b2cc796e4a
commit 82d54aec87
2 files changed
+11

No files matched your search

@@ -10,6 +10,14 @@ namespace OpenNest.WinForms.Tests.Forms;
public class PostVerificationFormTests
{
#pragma warning disable xUnit1031 // Dedicated STA; only await completed tasks, or explicitly pump until completion.
[Fact]
public void EveryFindingKindIsListed()
{
// A kind left out would raise the warning count with nothing to read.
Assert.Equal(Enum.GetValues<PostVerificationKind>().OrderBy(k => k),
PostVerificationForm.ListedKinds.OrderBy(k => k));
}
[Fact]
public void WarningsRequireFreshAcknowledgmentAndUncheckingRevokesPermission()
{
+3
View File
@@ -28,8 +28,11 @@ public partial class PostVerificationForm : Form
(PostVerificationKind.FixedLead, "Fixed leads"),
(PostVerificationKind.PierceZone, "Pierce zones"),
(PostVerificationKind.PartSpacing, "Part spacing"),
(PostVerificationKind.PartSupport, "Part support"),
};
internal static PostVerificationKind[] ListedKinds => Categories.Select(c => c.Kind).ToArray();
// Checks every plate always runs, so their tiles show even at zero.
private static readonly PostVerificationKind[] CoreChecks =
{