aj/OpenNest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: DetermineWinding used absolute area, always returned CCW

Browse Source 
Shape.Area() returns Math.Abs(signedArea), so DetermineWinding always
detected CCW regardless of actual winding. Use ToPolygon().RotationDirection()
which uses the signed area correctly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
AJ Isaacs
2026-04-02 12:16:15 -04:00
parent 64945220b9
commit 5bcad9667b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
OpenNest.Core/CNC/CuttingStrategy/ContourCuttingStrategy.cs
+4 -3
View File
@@ -186,9 +186,10 @@ namespace OpenNest.CNC.CuttingStrategy
public static RotationType DetermineWinding(Shape shape) public static RotationType DetermineWinding(Shape shape)
{ {
// Use signed area: positive = CCW, negative = CW if (shape.Entities.Count == 1 && shape.Entities[0] is Circle circle)
var area = shape.Area(); return circle.Rotation;
return area >= 0 ? RotationType.CCW : RotationType.CW;
return shape.ToPolygon().RotationDirection();
} }
private LeadIn ClampLeadInForCircle(LeadIn leadIn, Circle circle, Vector contourPoint, double normalAngle) private LeadIn ClampLeadInForCircle(LeadIn leadIn, Circle circle, Vector contourPoint, double normalAngle)