mirror of
https://github.com/ajisaacs/OpenNest.git
synced 2026-10-26 22:01:06 -04:00
chore(posts): stop naming the CI Fiber customer sample part
The Cincinnati sample used by the CI Fiber tests is a customer production part. Its geometry and NC were never tracked, but comments named its part number and fixture file names and quoted its date and a pierce coordinate. Replace them with generic wording and placeholder values; the fixture stays outside the repository, configured only in the gitignored test-config.json. Comment-only change.
This commit is contained in:
1 parent
cc2b3d1b81
commit
2d74d09023
4 files changed
+12
-11
No files matched your search
@@ -16,7 +16,7 @@ namespace OpenNest.Tests.CincinnatiCIFiber;
|
||||
|
||||
/// <summary>
|
||||
/// Output-contract tests for the Cincinnati CI Fiber post, checked against the
|
||||
/// structure of the machine sample NC (12992-4SS_NEST.nc): header block,
|
||||
/// structure of a Cincinnati machine sample NC: header block,
|
||||
/// restart jump, N-labelled contour blocks with /L macro lines, G41
|
||||
/// selection, trimmed coordinate format and the M50/M30/% tail.
|
||||
/// </summary>
|
||||
|
||||
@@ -16,19 +16,20 @@ using OpenNest.Posts.CincinnatiCIFiber;
|
||||
namespace OpenNest.Tests.CincinnatiCIFiber;
|
||||
|
||||
/// <summary>
|
||||
/// Regression against the real machine program: posts the reconstructed
|
||||
/// 12992-4SS nest (same part + layout as the sample NC) and compares contour
|
||||
/// counts, macro counts and perimeter geometry with 12992-4SS_NEST.nc.
|
||||
/// Regression against a real machine program: posts a nest reconstructed from
|
||||
/// a Cincinnati sample NC (same part and layout) and compares contour counts,
|
||||
/// macro counts and perimeter geometry with that NC. The sample is a customer
|
||||
/// production part, so the fixture stays outside the repository and is not
|
||||
/// named here.
|
||||
///
|
||||
/// Each placed part in the fixture carries the sample's own pierce, lead-in
|
||||
/// and cut moves as its saved cutting program (not locked). Posting those
|
||||
/// saved programs must reproduce the sample move for move; the other tests
|
||||
/// replace them with OpenNest's own lead-ins first.
|
||||
///
|
||||
/// The fixture lives outside the repository (/srv/shared). Configure it in
|
||||
/// OpenNest.Tests/test-config.json:
|
||||
/// { "CIFiberSampleNcPath": "/srv/shared/.../12992-4SS_NEST.nc",
|
||||
/// "CIFiberReconstructedNestPath": "/srv/shared/.../12992-4SS_NEST_reconstructed.nest" }
|
||||
/// Configure the fixture in OpenNest.Tests/test-config.json (gitignored):
|
||||
/// { "CIFiberSampleNcPath": "<path to the sample>.nc",
|
||||
/// "CIFiberReconstructedNestPath": "<path to the reconstructed>.nest" }
|
||||
/// Both must exist for the test to run; otherwise it skips.
|
||||
/// </summary>
|
||||
public class CIFiberSampleRegressionTests
|
||||
|
||||
@@ -6,7 +6,7 @@ namespace OpenNest.Posts.CincinnatiCIFiber
|
||||
/// <summary>
|
||||
/// Formats numeric values for the CI Fiber machine program.
|
||||
/// Coordinates: up to <see cref="PostedAccuracy"/> decimals with trailing
|
||||
/// zeros trimmed ("3.706", "5.01", "0"), never "-0" (sample NC format).
|
||||
/// zeros trimmed ("1.234", "5.01", "0"), never "-0" (sample NC format).
|
||||
/// Header values (V.E.*) use fixed decimals.
|
||||
/// </summary>
|
||||
public sealed class CIFiberFormatter
|
||||
|
||||
@@ -17,7 +17,7 @@ namespace OpenNest.Posts.CincinnatiCIFiber
|
||||
/// <code>
|
||||
/// ( <nest name> )
|
||||
/// ( CONFIGURATION - CI FIBER 8K )
|
||||
/// ( August 20, 2026 01:10 PM )
|
||||
/// ( <month d, yyyy hh:mm AM|PM> )
|
||||
/// ( Material = Mild Steel .060 )
|
||||
/// V.E.MATERIAL = "MSN" ... V.E.UNIT = 1
|
||||
/// G90
|
||||
@@ -43,7 +43,7 @@ namespace OpenNest.Posts.CincinnatiCIFiber
|
||||
/// %
|
||||
/// </code>
|
||||
///
|
||||
/// Coordinates are spaceless (G1X3.706Y47.488); arcs post I/J incremental
|
||||
/// Coordinates are spaceless (G1X1.234Y5.678); arcs post I/J incremental
|
||||
/// from the arc start (TF5200 G162 default). The first motion block after
|
||||
/// the G41/G42 selection is always LINEAR (TF5200 §13.2.4.1): contours
|
||||
/// without a lead-in move are rejected with a clear error.
|
||||
|
||||
Reference in new issue
Block a user