mirror of
https://github.com/ajisaacs/OpenNest.git
synced 2026-11-15 21:35:34 -05:00
Operators need to build kits from library drawings before they can be released. The Drawing Library dialog gains a Sets tab beside Drawings, so sets live where their drawings are browsed: list, search, archive, restore, history, and an editor whose Add Drawings reuses the library in a multi-select pick mode. The Drawings tab's menu shows which sets use a drawing and adds it to a chosen or new set. DrawingSetEditSession keeps a new set's id across a save whose reply was lost, so a retry adopts the stored set instead of creating it twice, and guards existing-set saves with the revision they were read at. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
273 lines
11 KiB
C#
273 lines
11 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Globalization;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using System.Net.Http;
|
|
using System.Threading.Tasks;
|
|
using System.Windows.Forms;
|
|
using OpenNest.Controls;
|
|
using OpenNest.Data;
|
|
|
|
namespace OpenNest.Forms
|
|
{
|
|
/// <summary>
|
|
/// Creates or edits one drawing set through <see cref="DrawingSetEditSession"/>: name,
|
|
/// customer, notes and the ordered members with a quantity each. Add Drawings picks from
|
|
/// the drawing library; a drawing already in the set is not added twice. Saving adds a
|
|
/// revision on the server, guarded by the revision the set was read at.
|
|
/// </summary>
|
|
public partial class EditDrawingSetForm : Form
|
|
{
|
|
private readonly DrawingSetEditSession session;
|
|
private bool loading;
|
|
private bool saving;
|
|
|
|
/// <summary>Shows a message and returns the operator's answer; replaced by tests.</summary>
|
|
internal Func<string, MessageBoxButtons, MessageBoxIcon, DialogResult> ShowMessage { get; set; }
|
|
|
|
/// <summary>Picks library drawings and the quantity to add them with (none when cancelled); replaced by tests.</summary>
|
|
internal Func<(IReadOnlyList<DrawingLibraryRecord> Drawings, int Quantity)> PickDrawings { get; set; }
|
|
|
|
/// <summary>The saved revision once the dialog closes with OK; otherwise null.</summary>
|
|
public DrawingSetRecord Saved { get; private set; }
|
|
|
|
public EditDrawingSetForm(DrawingSetEditSession session, IDrawingLibraryStore library, string serverUrl)
|
|
{
|
|
InitializeComponent();
|
|
this.session = session ?? throw new ArgumentNullException(nameof(session));
|
|
ArgumentNullException.ThrowIfNull(library);
|
|
ShowMessage = (text, buttons, icon) => MessageBox.Show(this, text, Text, buttons, icon);
|
|
PickDrawings = () =>
|
|
{
|
|
using var form = new DrawingLibraryForm(library, serverUrl);
|
|
return form.ShowDialog(this) == DialogResult.OK
|
|
? (form.PickedDrawings, form.PickedQuantity)
|
|
: (Array.Empty<DrawingLibraryRecord>(), 0);
|
|
};
|
|
|
|
GridStyle.Apply(memberGrid);
|
|
loading = true;
|
|
nameBox.Text = session.Name;
|
|
customerBox.Text = session.Customer;
|
|
notesBox.Text = session.Notes;
|
|
loading = false;
|
|
Text = session.IsNew
|
|
? "New Drawing Set"
|
|
: $"Edit Set '{session.Saved.Name}' — revision {session.Saved.Revision}";
|
|
Populate(session.Members.Count > 0 ? 0 : -1);
|
|
UpdateCommands();
|
|
}
|
|
|
|
private void Details_TextChanged(object sender, EventArgs e)
|
|
{
|
|
if (loading)
|
|
return;
|
|
session.Name = nameBox.Text;
|
|
session.Customer = customerBox.Text;
|
|
session.Notes = notesBox.Text;
|
|
UpdateCommands();
|
|
}
|
|
|
|
private void MemberGrid_CurrentCellChanged(object sender, EventArgs e) => UpdateCommands();
|
|
|
|
private void MemberGrid_CellValidating(object sender, DataGridViewCellValidatingEventArgs e)
|
|
{
|
|
if (e.ColumnIndex != quantityColumn.Index)
|
|
return;
|
|
var row = memberGrid.Rows[e.RowIndex];
|
|
if (int.TryParse(Convert.ToString(e.FormattedValue, CultureInfo.CurrentCulture), NumberStyles.Integer,
|
|
CultureInfo.CurrentCulture, out var quantity)
|
|
&& quantity >= 1 && quantity <= DrawingSetRules.MaxQuantity)
|
|
{
|
|
row.ErrorText = "";
|
|
return;
|
|
}
|
|
|
|
row.ErrorText = $"Quantity must be a whole number from 1 to {DrawingSetRules.MaxQuantity:N0}.";
|
|
statusLabel.Text = row.ErrorText;
|
|
e.Cancel = true;
|
|
}
|
|
|
|
// A programmatic EndEdit (Save, Remove, Move) commits without validating, so check again.
|
|
private void MemberGrid_CellEndEdit(object sender, DataGridViewCellEventArgs e)
|
|
{
|
|
if (e.ColumnIndex != quantityColumn.Index)
|
|
return;
|
|
var row = memberGrid.Rows[e.RowIndex];
|
|
var cell = row.Cells[e.ColumnIndex];
|
|
if (cell.Value is int quantity && quantity >= 1 && quantity <= DrawingSetRules.MaxQuantity)
|
|
{
|
|
session.SetQuantity(e.RowIndex, quantity);
|
|
row.ErrorText = "";
|
|
UpdateCommands();
|
|
return;
|
|
}
|
|
|
|
cell.Value = session.Members[e.RowIndex].Quantity;
|
|
row.ErrorText = $"Quantity must be a whole number from 1 to {DrawingSetRules.MaxQuantity:N0}.";
|
|
UpdateCommands();
|
|
statusLabel.Text = row.ErrorText;
|
|
}
|
|
|
|
// Validation refuses bad text before it is parsed; never show the grid's own error dialog.
|
|
private void MemberGrid_DataError(object sender, DataGridViewDataErrorEventArgs e) => e.ThrowException = false;
|
|
|
|
private void AddButton_Click(object sender, EventArgs e) => AddDrawings();
|
|
|
|
private void RemoveButton_Click(object sender, EventArgs e)
|
|
{
|
|
var index = SelectedIndex();
|
|
if (index < 0 || !memberGrid.EndEdit())
|
|
return;
|
|
session.RemoveAt(index);
|
|
Populate(System.Math.Min(index, session.Members.Count - 1));
|
|
UpdateCommands();
|
|
}
|
|
|
|
private void UpButton_Click(object sender, EventArgs e) => MoveSelected(-1);
|
|
|
|
private void DownButton_Click(object sender, EventArgs e) => MoveSelected(1);
|
|
|
|
private void MoveSelected(int offset)
|
|
{
|
|
var index = SelectedIndex();
|
|
if (index < 0 || !memberGrid.EndEdit() || !session.Move(index, offset))
|
|
return;
|
|
Populate(index + offset);
|
|
UpdateCommands();
|
|
}
|
|
|
|
/// <summary>Adds the drawings picked from the library, skipping those already in the set.</summary>
|
|
internal void AddDrawings()
|
|
{
|
|
if (saving || !memberGrid.EndEdit())
|
|
return;
|
|
var (drawings, quantity) = PickDrawings();
|
|
if (drawings == null || drawings.Count == 0 || IsDisposed)
|
|
return;
|
|
|
|
var result = session.AddDrawings(drawings, quantity);
|
|
Populate(result.Added.Count > 0 ? session.Members.Count - 1 : SelectedIndex());
|
|
UpdateCommands();
|
|
var added = result.Added.Count == 1 ? $"Added '{result.Added[0].Name}'." : $"Added {result.Added.Count} drawings.";
|
|
statusLabel.Text = result.AlreadyMembers.Count == 0
|
|
? added
|
|
: $"{added} Already in the set: {string.Join(", ", result.AlreadyMembers.Select(d => $"'{d.Name}'"))}.";
|
|
}
|
|
|
|
private async void SaveButton_Click(object sender, EventArgs e) => await SaveAsync();
|
|
|
|
/// <summary>Saves the set as a new revision; closes with OK on success.</summary>
|
|
internal async Task SaveAsync()
|
|
{
|
|
if (saving || !memberGrid.EndEdit() || session.GetError() != null || !session.IsChanged)
|
|
return;
|
|
|
|
saving = true;
|
|
UpdateCommands();
|
|
statusLabel.Text = "Saving...";
|
|
try
|
|
{
|
|
Saved = await session.SaveAsync();
|
|
if (IsDisposed)
|
|
return;
|
|
DialogResult = DialogResult.OK;
|
|
Close();
|
|
}
|
|
catch (Exception ex) when (ex is IOException || ex is HttpRequestException || ex is TaskCanceledException
|
|
|| ex is ArgumentException)
|
|
{
|
|
// A conflict (someone else saved first) is an IOException too; nothing was changed.
|
|
if (IsDisposed)
|
|
return;
|
|
statusLabel.Text = "";
|
|
ShowMessage(ex is DrawingSetSaveConflictException
|
|
? ex.Message + Environment.NewLine + Environment.NewLine + "Cancel to reload the set, then edit it again."
|
|
: $"Could not save the set: {ex.Message}", MessageBoxButtons.OK, MessageBoxIcon.Warning);
|
|
}
|
|
finally
|
|
{
|
|
saving = false;
|
|
if (!IsDisposed)
|
|
UpdateCommands();
|
|
}
|
|
}
|
|
|
|
private void EditDrawingSetForm_FormClosing(object sender, FormClosingEventArgs e)
|
|
{
|
|
if (saving)
|
|
{
|
|
e.Cancel = true;
|
|
return;
|
|
}
|
|
|
|
if (DialogResult == DialogResult.OK || !HasEdits())
|
|
return;
|
|
if (ShowMessage("Discard the changes to this set?", MessageBoxButtons.YesNo, MessageBoxIcon.Question) != DialogResult.Yes)
|
|
e.Cancel = true;
|
|
}
|
|
|
|
private bool HasEdits() =>
|
|
session.IsNew
|
|
? !string.IsNullOrWhiteSpace(session.Name) || !string.IsNullOrWhiteSpace(session.Customer)
|
|
|| !string.IsNullOrWhiteSpace(session.Notes) || session.Members.Count > 0
|
|
: session.IsChanged;
|
|
|
|
private void Populate(int select)
|
|
{
|
|
memberGrid.Rows.Clear();
|
|
foreach (var member in session.Members)
|
|
{
|
|
var drawing = member.Drawing;
|
|
var index = memberGrid.Rows.Add(
|
|
drawing?.Name ?? member.DrawingId.ToString(),
|
|
drawing?.MaterialName ?? "",
|
|
drawing?.MaterialGrade ?? "",
|
|
drawing == null ? "" : drawing.Thickness.ToString("0.####", CultureInfo.CurrentCulture),
|
|
drawing?.Units.ToString() ?? "",
|
|
drawing?.CutType.ToString() ?? "",
|
|
member.Quantity,
|
|
Warning(drawing));
|
|
memberGrid.Rows[index].Tag = member;
|
|
}
|
|
|
|
if (select >= 0 && select < memberGrid.Rows.Count)
|
|
memberGrid.CurrentCell = memberGrid.Rows[select].Cells[drawingColumn.Index];
|
|
else
|
|
memberGrid.ClearSelection();
|
|
|
|
var parts = session.Members.Sum(m => (long)m.Quantity);
|
|
summaryLabel.Text = session.Members.Count == 0
|
|
? "No drawings yet. Choose Add Drawings to pick them from the library."
|
|
: $"{session.Members.Count:N0} drawing{(session.Members.Count == 1 ? "" : "s")}, {parts:N0} part{(parts == 1 ? "" : "s")} per kit";
|
|
}
|
|
|
|
private static string Warning(DrawingLibraryRecord drawing)
|
|
{
|
|
if (drawing == null)
|
|
return "";
|
|
if (drawing.Archived)
|
|
return "Archived in the library: skipped on release unless included";
|
|
if (string.IsNullOrWhiteSpace(drawing.MaterialName) || !(drawing.Thickness > 0))
|
|
return "No material or thickness: cannot be released until set in the library";
|
|
return "";
|
|
}
|
|
|
|
private int SelectedIndex() => memberGrid.CurrentRow?.Index ?? -1;
|
|
|
|
private void UpdateCommands()
|
|
{
|
|
var index = SelectedIndex();
|
|
var error = session.GetError();
|
|
addButton.Enabled = !saving;
|
|
removeButton.Enabled = !saving && index >= 0;
|
|
upButton.Enabled = !saving && index > 0;
|
|
downButton.Enabled = !saving && index >= 0 && index < session.Members.Count - 1;
|
|
saveButton.Enabled = !saving && error == null && session.IsChanged;
|
|
if (!saving)
|
|
statusLabel.Text = error == null ? "" : char.ToUpper(error[0], CultureInfo.CurrentCulture) + error[1..];
|
|
}
|
|
}
|
|
}
|