Files
OpenNest/OpenNest.IO.Tests/BreakoffPersistenceTests.cs
T
ajandClaude Opus 5.5 7ce5e73a82 refactor: share duplicated paging, HTTP and helper code
Roslyn duplicate scans found the same code copied across layers:
- Data: the three browse sessions share BrowseSession<TPage, TSort>;
  the remote clients share NestServerHttp (JSON options, If-Match,
  error text).
- WinForms: five paged lists share BrowsePager for loading text,
  navigation, sort glyphs and failure messages. The Add Drawings to
  Release, Drawing Library and set browser dialogs now dispose their
  browse sessions.
- Server: NestQueryRequest reuses DrawingLibraryRequest's helpers;
  revision history queries share count and paging binds.
- Engine: RemnantPlateNester delegates to DefaultPlateNester;
  CuttingPlanService reuses JointCuttingPlanSearch.Map.
- Core: LineArc and CleanHole lead-ins share LineArcApproach with
  unchanged arithmetic order, so output is bit-identical.
- IO: Dxf.GetGeometry overloads share one reader; .nest JSON test
  helpers move to NestArchiveJson.

Also fixes the production compiler warnings (CS8632, CS8603, CS0108)
and moves a test off an obsolete forwarding API.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 08:45:36 -04:00

86 lines
2.9 KiB
C#

using System.IO.Compression;
using System.Text;
using System.Text.Json.Nodes;
using OpenNest.Breakoffs;
using static OpenNest.IO.Tests.NestArchiveJson;
namespace OpenNest.IO.Tests;
public class BreakoffPersistenceTests
{
private static Drawing WithBreakoff()
{
var drawing = DrawingPackageFixture.Build();
drawing.Breakoffs.Add(new Breakoff
{
EdgeIds = [Guid.NewGuid(), Guid.NewGuid()],
TabWidth = 0.05,
Flip = true,
TabCenters = [0.025, 1.5, 3.2],
});
return drawing;
}
[Fact]
public void Breakoffs_RoundTripEveryField()
{
var drawing = WithBreakoff();
var original = drawing.Breakoffs[0];
var (restored, warnings) = RoundTrip(Write(drawing));
Assert.Empty(warnings);
var breakoff = Assert.Single(Assert.Single(restored.Drawings).Breakoffs);
Assert.Equal(original.EdgeIds, breakoff.EdgeIds);
Assert.Equal((0.05, true), (breakoff.TabWidth, breakoff.Flip));
Assert.Equal(original.TabCenters, breakoff.TabCenters);
}
[Fact]
public void BreakCutMoves_KeepTheirLayer()
{
var drawing = DrawingPackageFixture.Build();
drawing.Program.MoveTo(4, 5);
drawing.Program.Codes.Add(new OpenNest.CNC.LinearMove(1, 0) { Layer = OpenNest.CNC.LayerType.Break });
drawing.Program.Codes.Add(new OpenNest.CNC.ArcMove(1, 1, 0, 1) { Layer = OpenNest.CNC.LayerType.Break });
var (restored, _) = RoundTrip(Write(drawing));
var moves = Assert.Single(restored.Drawings).Program.Codes.OfType<OpenNest.CNC.Motion>()
.Where(m => m is OpenNest.CNC.LinearMove { Layer: OpenNest.CNC.LayerType.Break }
or OpenNest.CNC.ArcMove { Layer: OpenNest.CNC.LayerType.Break });
Assert.Equal(2, moves.Count());
}
[Fact]
public void NoBreakoffs_AreOmittedFromTheFile()
{
var archive = Write(DrawingPackageFixture.Build());
Assert.False(NestJson(archive)["drawings"]![0]!.AsObject().ContainsKey("breakoffs"));
Assert.Empty(Assert.Single(RoundTrip(archive).Nest.Drawings).Breakoffs);
}
[Fact]
public void UnreadableBreakoff_IsDroppedWithAWarning_AndTheDrawingLoads()
{
var archive = Write(WithBreakoff());
var json = NestJson(archive);
json["drawings"]![0]!["breakoffs"]![0]!["tabWidth"] = 0;
var (restored, warnings) = RoundTrip(ReplaceNestJson(archive, json));
Assert.Empty(Assert.Single(restored.Drawings).Breakoffs);
Assert.Contains(warnings, w => w.Contains("breakoff 1 could not be read"));
}
private static byte[] Write(Drawing drawing)
{
var nest = new Nest(drawing.Name) { Units = Units.Inches };
nest.Drawings.Add(drawing);
using var stream = new MemoryStream();
Assert.True(new NestWriter(nest).Write(stream));
return stream.ToArray();
}
}