The CAD converter and BOM import were stripping the leading RapidMove after normalizing program coordinates to origin. This left programs starting with a LinearMove, causing the post-processor to use that endpoint as the pierce point — making the first contour edge zero-length and losing the closing segment (e.g. the bottom line on curved parts). Root cause: CadConverterForm.GetDrawings(), OnSplitClicked(), and BomImportForm all called pgm.Codes.RemoveAt(0) after offsetting the rapid to origin. The rapid at (0,0) is a harmless no-op that marks the contour start point for downstream processing. Also adds EnsureLeadingRapid() safety net in the Cincinnati post for existing nest files that already have the rapid stripped. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
177 lines
5.4 KiB
C#
177 lines
5.4 KiB
C#
using System.Collections.Generic;
|
|
using OpenNest.CNC;
|
|
using OpenNest.Geometry;
|
|
using OpenNest.Math;
|
|
|
|
namespace OpenNest.Posts.Cincinnati;
|
|
|
|
/// <summary>
|
|
/// Shared utilities for splitting CNC programs into features and classifying them.
|
|
/// </summary>
|
|
public static class FeatureUtils
|
|
{
|
|
/// <summary>
|
|
/// Splits a flat list of codes into feature groups, breaking on rapid moves.
|
|
/// Each feature starts with a rapid move followed by cutting/etching moves.
|
|
/// </summary>
|
|
public static List<List<ICode>> SplitByRapids(List<ICode> codes)
|
|
{
|
|
var features = new List<List<ICode>>();
|
|
List<ICode> current = null;
|
|
|
|
foreach (var code in codes)
|
|
{
|
|
if (code is RapidMove)
|
|
{
|
|
if (current != null)
|
|
features.Add(current);
|
|
current = new List<ICode> { code };
|
|
}
|
|
else
|
|
{
|
|
current ??= new List<ICode>();
|
|
current.Add(code);
|
|
}
|
|
}
|
|
|
|
if (current != null && current.Count > 0)
|
|
features.Add(current);
|
|
|
|
return features;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Classifies features as etch or cut and orders etch features before cut features.
|
|
/// </summary>
|
|
public static List<(List<ICode> codes, bool isEtch)> ClassifyAndOrder(List<List<ICode>> features)
|
|
{
|
|
var result = new List<(List<ICode>, bool)>();
|
|
var etch = new List<List<ICode>>();
|
|
var cut = new List<List<ICode>>();
|
|
|
|
foreach (var f in features)
|
|
{
|
|
if (IsEtch(f))
|
|
etch.Add(f);
|
|
else
|
|
cut.Add(f);
|
|
}
|
|
|
|
foreach (var f in etch)
|
|
result.Add((f, true));
|
|
foreach (var f in cut)
|
|
result.Add((f, false));
|
|
|
|
return result;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Splits a part's program into features by rapids, classifies each as etch or cut,
|
|
/// and orders etch features before cut features.
|
|
/// </summary>
|
|
public static List<(List<ICode> codes, bool isEtch)> SplitAndClassify(Part part)
|
|
{
|
|
part.Program.Mode = Mode.Absolute;
|
|
var codes = part.Program.Codes;
|
|
|
|
// If no leading rapid, the first contour segment would be lost because
|
|
// the feature writer pierces at the first motion endpoint. Insert a
|
|
// synthetic rapid at the contour's return point to preserve closure.
|
|
if (codes.Count > 0 && codes[0] is not RapidMove)
|
|
{
|
|
for (var i = codes.Count - 1; i >= 0; i--)
|
|
{
|
|
if (codes[i] is Motion lastMotion)
|
|
{
|
|
var withRapid = new List<ICode>(codes.Count + 1);
|
|
withRapid.Add(new RapidMove(lastMotion.EndPoint));
|
|
withRapid.AddRange(codes);
|
|
codes = withRapid;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
return ClassifyAndOrder(SplitByRapids(codes));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Returns true if any non-rapid move in the feature has LayerType.Scribe.
|
|
/// </summary>
|
|
public static bool IsEtch(List<ICode> codes)
|
|
{
|
|
foreach (var code in codes)
|
|
{
|
|
if (code is LinearMove linear && linear.Layer == LayerType.Scribe)
|
|
return true;
|
|
if (code is ArcMove arc && arc.Layer == LayerType.Scribe)
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Computes the total cut distance of a feature by summing segment lengths.
|
|
/// </summary>
|
|
public static double ComputeCutDistance(List<ICode> codes)
|
|
{
|
|
var distance = 0.0;
|
|
var currentPos = Vector.Zero;
|
|
|
|
foreach (var code in codes)
|
|
{
|
|
if (code is RapidMove rapid)
|
|
currentPos = rapid.EndPoint;
|
|
else if (code is LinearMove linear)
|
|
{
|
|
distance += currentPos.DistanceTo(linear.EndPoint);
|
|
currentPos = linear.EndPoint;
|
|
}
|
|
else if (code is ArcMove arc)
|
|
{
|
|
distance += ComputeArcLength(currentPos, arc);
|
|
currentPos = arc.EndPoint;
|
|
}
|
|
}
|
|
|
|
return distance;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Computes the arc length from the current position through an arc move.
|
|
/// Uses radius * sweep angle instead of chord length.
|
|
/// </summary>
|
|
public static double ComputeArcLength(Vector startPos, ArcMove arc)
|
|
{
|
|
var radius = startPos.DistanceTo(arc.CenterPoint);
|
|
if (radius < Tolerance.Epsilon)
|
|
return 0.0;
|
|
|
|
// Full circle: start ≈ end
|
|
if (Tolerance.IsEqualTo(startPos.X, arc.EndPoint.X)
|
|
&& Tolerance.IsEqualTo(startPos.Y, arc.EndPoint.Y))
|
|
return 2.0 * System.Math.PI * radius;
|
|
|
|
var startAngle = System.Math.Atan2(
|
|
startPos.Y - arc.CenterPoint.Y,
|
|
startPos.X - arc.CenterPoint.X);
|
|
var endAngle = System.Math.Atan2(
|
|
arc.EndPoint.Y - arc.CenterPoint.Y,
|
|
arc.EndPoint.X - arc.CenterPoint.X);
|
|
|
|
double sweep;
|
|
if (arc.Rotation == RotationType.CW)
|
|
{
|
|
sweep = startAngle - endAngle;
|
|
if (sweep <= 0) sweep += 2.0 * System.Math.PI;
|
|
}
|
|
else
|
|
{
|
|
sweep = endAngle - startAngle;
|
|
if (sweep <= 0) sweep += 2.0 * System.Math.PI;
|
|
}
|
|
|
|
return radius * sweep;
|
|
}
|
|
}
|