Files
OpenNest/OpenNest.Engine/CirclePacking/FillEndOdd.cs
T
ajandClaude Opus 5.5 6e2e27d6fc fix(engine): stop staggered circle fills overlapping
Staggered stripes were spaced only so adjacent stripes touched
diagonally. When the in-stripe pitch stretched past sqrt(3)*D, stripes
two apart, which sit directly over each other, came closer than a
diameter. Clamp the stripe spacing to at least a radius in both fills.

FillEndOdd also divided by zero when a single circle fit per stripe;
it now stacks those stripes a diameter apart. FillEndEven now clones
the template item, so placed circles keep its radius instead of zero.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 12:49:36 -04:00

85 lines
2.8 KiB
C#

using System;
using OpenNest.Geometry;
using OpenNest.Math;
namespace OpenNest.Engine.CirclePacking
{
internal class FillEndOdd : FillEngine
{
public FillEndOdd(Bin bin)
: base(bin) { }
public override void Fill(Item item)
{
var bin1 = FillHorizontal(item);
var bin2 = FillVertical(item);
if (bin1.Items.Count > bin2.Items.Count)
Bin.Items.AddRange(bin1.Items);
else
Bin.Items.AddRange(bin2.Items);
}
public override void Fill(Item item, int maxCount)
{
throw new NotImplementedException();
}
private Bin FillHorizontal(Item item) => FillAxis(item, horizontal: true);
private Bin FillVertical(Item item) => FillAxis(item, horizontal: false);
private Bin FillAxis(Item item, bool horizontal)
{
var bin = Bin.Clone() as Bin;
var max = new Vector(
bin.Right - item.BoundingBox.Right + Tolerance.Epsilon,
bin.Top - item.BoundingBox.Top + Tolerance.Epsilon
);
var primarySize = horizontal ? bin.Width : bin.Length;
var count = System.Math.Floor((primarySize + Tolerance.Epsilon) / item.Diameter);
if (count == 0)
return bin;
// A single circle per stripe cannot stagger; stack the stripes a diameter apart.
var primaryOffset = count > 1
? (primarySize - item.Diameter) / (count - 1)
: double.PositiveInfinity;
// Adjacent stripes touch diagonally, but stripes two apart sit directly over each
// other, so the stripe spacing can never drop below a radius.
var secondaryOffset = count > 1
? System.Math.Max(Trigonometry.Height(primaryOffset * 0.5, item.Diameter), item.Diameter * 0.5)
: item.Diameter;
var outerStart = horizontal ? bin.Y : bin.X;
var outerMax = horizontal ? max.Y : max.X;
var innerStart = horizontal ? bin.X : bin.Y;
var innerMax = horizontal ? max.X : max.Y;
var stripe = 0;
for (var outer = outerStart; outer <= outerMax; outer += secondaryOffset)
{
var inner = count > 1 && stripe.IsOdd() ? innerStart + primaryOffset * 0.5 : innerStart;
for (; inner <= innerMax; inner += primaryOffset)
{
var addedItem = item.Clone();
addedItem.Center = horizontal
? new Vector(inner, outer)
: new Vector(outer, inner);
bin.Items.Add(addedItem);
}
stripe++;
}
return bin;
}
}
}