Every nesting-geometry consumer filtered only rapids, so scribe/etch moves counted as part material. An etch tick that ends a hair outside the outline (PEP bend ticks start on the notch edge) made the part "open geometry leaving the material region": the job validator threw and every built-in engine plus Gpt6Astra crashed on real PEP jobs (PT75, drawing 4980 A01 PT77). Marks are only on the surface, so they should never affect placement, collision, area, or validation. - SpecialLayers.IsMaterial excludes Rapid and Scribe; used by drawing area, canonical angle, part collision, PartGeometry, plate perimeter, best-fit/pair evaluation, rotation analysis, GPU evaluators, and both validators. Timing, display, splitting and posts still see marks. - ConvertGeometry also maps the saved SCRIBE layer name to Scribe, so programs rebuilt from stored entities keep their marks. - NestReader repairs older files (e.g. PepNestExport output) whose programs saved etch as cut moves while source entities kept SCRIBE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
245 lines
7.9 KiB
C#
245 lines
7.9 KiB
C#
using OpenNest.CNC;
|
|
using OpenNest.Geometry;
|
|
using OpenNest.Engine.Jobs;
|
|
|
|
namespace OpenNest.Engine.Tests.Jobs;
|
|
|
|
public class NestJobValidationTests
|
|
{
|
|
[Fact]
|
|
public void IncrementalContoursUseAccumulatedCoordinates()
|
|
{
|
|
var program = new Program(Mode.Incremental);
|
|
program.MoveTo(0, 0);
|
|
program.LineTo(4, 0);
|
|
program.LineTo(0, 3);
|
|
program.LineTo(-4, 0);
|
|
program.LineTo(0, -3);
|
|
var job = new NestJob(
|
|
new[] { new NestJobPart("part", PartGeometrySnapshot.FromProgram(program), 1) },
|
|
new[] { new NestPlateStock("stock", new Size(10, 10), 1) }
|
|
);
|
|
|
|
var result = Solve(job, new NestJobPlacement("part", 0, 0, 0, 0));
|
|
|
|
Assert.Equal(NestJobStatus.Complete, result.Status);
|
|
Assert.Equal(new PartFulfillment("part", 1, 1, 0), Assert.Single(result.Fulfillment));
|
|
}
|
|
|
|
[Fact]
|
|
public void CandidateInsideAnotherRequirementsHoleDoesNotOverlapMaterial()
|
|
{
|
|
var outer = new NestJobPart(
|
|
"outer",
|
|
PartGeometrySnapshot.FromProgram(RectangleWithHole()),
|
|
1
|
|
);
|
|
var inner = new NestJobPart(
|
|
"inner",
|
|
PartGeometrySnapshot.FromProgram(TestDrawingFactory.Rectangle(2, 2)),
|
|
1
|
|
);
|
|
var job = new NestJob(
|
|
new[] { outer, inner },
|
|
new[] { new NestPlateStock("stock", new Size(20, 20), 1) }
|
|
);
|
|
|
|
var result = Solve(
|
|
job,
|
|
new NestJobPlacement("outer", 0, 0, 0, 0),
|
|
new NestJobPlacement("inner", 0, 4, 4, 0)
|
|
);
|
|
|
|
Assert.Equal(NestJobStatus.Complete, result.Status);
|
|
Assert.Single(result.Plates);
|
|
Assert.Equal(2, result.Plates[0].Placements.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void SmallCornerOverlapIsRejected()
|
|
{
|
|
var part = new NestJobPart(
|
|
"part",
|
|
PartGeometrySnapshot.FromProgram(TestDrawingFactory.Rectangle(10, 10)),
|
|
2
|
|
);
|
|
var job = new NestJob(
|
|
new[] { part },
|
|
new[] { new NestPlateStock("stock", new Size(20, 20), 1) }
|
|
);
|
|
|
|
Assert.Throws<InvalidOperationException>(() =>
|
|
Solve(
|
|
job,
|
|
new NestJobPlacement("part", 0, 0, 0, 0),
|
|
new NestJobPlacement("part", 1, 9, 9, 0)
|
|
)
|
|
);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(10.0, 0.0)]
|
|
[InlineData(10.0, 10.0)]
|
|
public void BoundaryContactWithZeroSpacingIsAccepted(double x, double y)
|
|
{
|
|
var part = new NestJobPart(
|
|
"part",
|
|
PartGeometrySnapshot.FromProgram(TestDrawingFactory.Rectangle(10, 10)),
|
|
2
|
|
);
|
|
var job = new NestJob(
|
|
new[] { part },
|
|
new[] { new NestPlateStock("stock", new Size(20, 20), 1) }
|
|
);
|
|
|
|
var result = Solve(
|
|
job,
|
|
new NestJobPlacement("part", 0, 0, 0, 0),
|
|
new NestJobPlacement("part", 1, x, y, 0)
|
|
);
|
|
|
|
Assert.Equal(NestJobStatus.Complete, result.Status);
|
|
Assert.Equal(2, Assert.Single(result.Plates).Placements.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void UnknownOrOverproducingCandidateFailsBeforeCommitWithoutChangingInput()
|
|
{
|
|
var reports = new List<NestJobProgress>();
|
|
var part = new NestJobPart(
|
|
"part",
|
|
PartGeometrySnapshot.FromProgram(TestDrawingFactory.Rectangle(2, 2)),
|
|
1
|
|
);
|
|
var stock = new NestPlateStock("stock", new Size(20, 20), 1);
|
|
var job = new NestJob(new[] { part }, new[] { stock });
|
|
var runner = new NestJobRunner(_ => new CandidateNester(
|
|
new[]
|
|
{
|
|
new NestJobPlacement("part", 0, 0, 0, 0),
|
|
new NestJobPlacement("unknown", 0, 4, 0, 0),
|
|
}
|
|
));
|
|
|
|
Assert.Throws<InvalidOperationException>(() =>
|
|
runner.Solve(job, new InlineProgress(reports.Add))
|
|
);
|
|
|
|
Assert.Equal(1, job.Parts[0].Quantity);
|
|
Assert.Equal(1, job.Plates[0].Quantity);
|
|
Assert.DoesNotContain(reports, report => report.Stage == NestJobStage.PlateCommitted);
|
|
}
|
|
|
|
[Fact]
|
|
public void CandidateThatOverproducesIsRejectedRatherThanClamped()
|
|
{
|
|
var part = new NestJobPart(
|
|
"part",
|
|
PartGeometrySnapshot.FromProgram(TestDrawingFactory.Rectangle(2, 2)),
|
|
1
|
|
);
|
|
var job = new NestJob(
|
|
new[] { part },
|
|
new[] { new NestPlateStock("stock", new Size(20, 20), 1) }
|
|
);
|
|
|
|
Assert.Throws<InvalidOperationException>(() =>
|
|
Solve(
|
|
job,
|
|
new NestJobPlacement("part", 0, 0, 0, 0),
|
|
new NestJobPlacement("part", 1, 4, 0, 0)
|
|
)
|
|
);
|
|
|
|
Assert.Equal(1, job.Parts[0].Quantity);
|
|
Assert.Equal(1, job.Plates[0].Quantity);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(true)]
|
|
[InlineData(false)]
|
|
public void OpenOrZeroLengthContoursAreRejected(bool zeroLength)
|
|
{
|
|
var program = new Program();
|
|
program.MoveTo(0, 0);
|
|
program.LineTo(4, 0);
|
|
if (zeroLength)
|
|
program.LineTo(4, 0);
|
|
program.LineTo(4, 3);
|
|
program.LineTo(0, 3);
|
|
if (zeroLength)
|
|
program.LineTo(0, 0);
|
|
var job = new NestJob(
|
|
new[] { new NestJobPart("part", PartGeometrySnapshot.FromProgram(program), 1) },
|
|
new[] { new NestPlateStock("stock", new Size(20, 20), 1) }
|
|
);
|
|
|
|
Assert.Throws<ArgumentException>(() =>
|
|
new NestJobRunner(_ => new CandidateNester(Array.Empty<NestJobPlacement>())).Solve(job)
|
|
);
|
|
}
|
|
|
|
[Fact]
|
|
public void EtchMarksAreLeftOutOfNestingGeometry()
|
|
{
|
|
// The etch tick sticks 0.5 past the right edge. As material it would be open geometry
|
|
// leaving the part and would overlap the neighbour placed 0.2 away; as a mark it is ignored.
|
|
var job = new NestJob(
|
|
new[] { new NestJobPart("part", PartGeometrySnapshot.FromProgram(RectangleWithEtch(LayerType.Scribe)), 2) },
|
|
new[] { new NestPlateStock("stock", new Size(30, 30), 1) }
|
|
);
|
|
|
|
var result = Solve(job, new NestJobPlacement("part", 0, 0, 0, 0), new NestJobPlacement("part", 1, 10.2, 0, 0));
|
|
|
|
Assert.Equal(NestJobStatus.Complete, result.Status);
|
|
Assert.Equal(new PartFulfillment("part", 2, 2, 0), Assert.Single(result.Fulfillment));
|
|
}
|
|
|
|
[Fact]
|
|
public void OpenCutGeometryLeavingThePartIsStillRejected()
|
|
{
|
|
var job = new NestJob(
|
|
new[] { new NestJobPart("part", PartGeometrySnapshot.FromProgram(RectangleWithEtch(LayerType.Cut)), 1) },
|
|
new[] { new NestPlateStock("stock", new Size(30, 30), 1) }
|
|
);
|
|
|
|
Assert.Throws<ArgumentException>(() => Solve(job, new NestJobPlacement("part", 0, 0, 0, 0)));
|
|
}
|
|
|
|
private static Program RectangleWithEtch(LayerType etchLayer)
|
|
{
|
|
var program = TestDrawingFactory.Rectangle(10, 10);
|
|
program.MoveTo(9.5, 5);
|
|
program.Codes.Add(new LinearMove(10.5, 5) { Layer = etchLayer });
|
|
return program;
|
|
}
|
|
|
|
private static NestJobResult Solve(NestJob job, params NestJobPlacement[] placements) =>
|
|
new NestJobRunner(_ => new CandidateNester(placements)).Solve(job);
|
|
|
|
private static Program RectangleWithHole()
|
|
{
|
|
var program = TestDrawingFactory.Rectangle(10, 10);
|
|
program.MoveTo(3, 3);
|
|
program.LineTo(3, 7);
|
|
program.LineTo(7, 7);
|
|
program.LineTo(7, 3);
|
|
program.LineTo(3, 3);
|
|
return program;
|
|
}
|
|
|
|
private sealed class CandidateNester(IEnumerable<NestJobPlacement> placements) : IPlateNester
|
|
{
|
|
public PlateCandidate Place(
|
|
PlatePlacementRequest request,
|
|
IProgress<NestJobProgress>? progress = null,
|
|
CancellationToken token = default
|
|
) => new(placements);
|
|
}
|
|
|
|
private sealed class InlineProgress(Action<NestJobProgress> report) : IProgress<NestJobProgress>
|
|
{
|
|
public void Report(NestJobProgress value) => report(value);
|
|
}
|
|
}
|