Files
OpenNest/OpenNest.Engine/Fill/RemnantComparer.cs
T
ajandClaude Opus 5.5 b550640ef0 refactor: merge duplicated geometry, settings-file and form helpers
Roslyn Bridge flagged these as copy-paste clusters; each pair now shares
one implementation so a fix lands everywhere at once:

- Shape.OffsetInward/OffsetOutward differed only in the target winding.
- BestFitFinder kept its own copy of SpatialQuery's arc-extreme points.
- SplitDrawingForm rebuilt DrawingSplitter's clip-region grid for preview.
- GeometryOptimizer's collinear/coradial finders (one misspelled
  GetCoradialArs) become one generic FindRelated.
- Five settings files repeated the write-with-retry loop, and two also
  repeated the unit parser and unreadable-file filter (SettingsFile).
- ClampsForm and SupportGridForm repeated their row/box builders.
- Vertical/HorizontalRemnantComparer share a RemnantComparer base.

Behavior is unchanged except that Engine/NestStorage settings loads now
also tolerate NotSupported/Security exceptions, matching the other
settings files' never-throw contract.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-30 12:59:47 -04:00

60 lines
1.8 KiB
C#

using System.Collections.Generic;
using OpenNest.Geometry;
using OpenNest.Math;
namespace OpenNest.Engine.Fill
{
/// <summary>
/// Ranks fill results to keep one side of the work area free for a remnant.
/// Tiebreak chain: count > smallest extent along the ranked axis > highest density.
/// </summary>
public abstract class RemnantComparer : IFillComparer
{
/// <summary>The lower edge of a bounding box along the ranked axis.</summary>
protected abstract double Low(Box box);
/// <summary>The upper edge of a bounding box along the ranked axis.</summary>
protected abstract double High(Box box);
public bool IsBetter(List<Part> candidate, List<Part> current, Box workArea)
{
if (candidate == null || candidate.Count == 0)
return false;
if (current == null || current.Count == 0)
return true;
if (candidate.Count != current.Count)
return candidate.Count > current.Count;
var candExtent = Extent(candidate);
var currExtent = Extent(current);
if (!candExtent.IsEqualTo(currExtent))
return candExtent < currExtent;
return FillScore.Compute(candidate, workArea).Density
> FillScore.Compute(current, workArea).Density;
}
private double Extent(List<Part> parts)
{
var min = double.MaxValue;
var max = double.MinValue;
foreach (var part in parts)
{
var bb = part.BoundingBox;
var low = Low(bb);
var high = High(bb);
if (low < min)
min = low;
if (high > max)
max = high;
}
return max - min;
}
}
}