mirror of
https://github.com/ajisaacs/OpenNest.git
synced 2026-11-19 03:37:40 -05:00
refactor(file-menu): regroup the export and report commands
The File menu ran six output commands together with no separators, and "Export" / "Export All" didn't say what they exported. Group them by what they produce: - Save Copy as .nest File... (was Export .nest...) moves next to Save As, since it writes the nest file rather than exporting a plate. - Export Plate... / Export All Plates... (were Export / Export All) get their own group and the "..." their save dialogs call for. - Nest Report... / Part Printouts... (were View ...) form a reports group. - Storage Mode... gets its own separator above Exit. Export Nest Report... is removed: the report viewer already has Save As (available even without WebView2), so it was a second path to the same PDF. Its guard and failure tests now drive the viewer path, and the atomic-write test calls WriteNestReport directly. The Avalonia prototype's matching command is renamed too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
755f021092
commit
ecd0bba4eb
10 files changed
+90
-170
No files matched your search
+23
-24
@@ -1,23 +1,23 @@
|
||||
# Nest report PDF export
|
||||
|
||||
Desktop: **File -> Export Nest Report...** writes `<nest-name>.report.pdf` for the
|
||||
active nest's whole job through an overwrite-confirming save dialog. The command
|
||||
is disabled without an open document and during a background database save, and
|
||||
it refuses to run while whole-job nesting, an open progress window, interactive
|
||||
fill or a busy plate action holds the nest or any second window sharing it. After
|
||||
the dialog closes, the target and those conditions are revalidated; the snapshot
|
||||
is then captured synchronously on the UI thread and only that detached snapshot
|
||||
reaches the renderer. Export never changes the selected plate, dirty state,
|
||||
timestamps or quantities, and it never touches post selection, verification or
|
||||
CNC output. There are no persisted report settings or templates.
|
||||
Desktop: **File -> Nest Report...** renders `<nest-name>.report.pdf` for the
|
||||
active nest's whole job. The command is disabled without an open document and
|
||||
during a background database save, and it refuses to run while whole-job
|
||||
nesting, an open progress window, interactive fill or a busy plate action holds
|
||||
the nest or any second window sharing it. The target and those conditions are
|
||||
revalidated before the write; the snapshot is then captured synchronously on the
|
||||
UI thread and only that detached snapshot reaches the renderer. Reporting never
|
||||
changes the selected plate, dirty state, timestamps or quantities, and it never
|
||||
touches post selection, verification or CNC output. There are no persisted report
|
||||
settings or templates.
|
||||
|
||||
**File -> View Nest Report...** runs the same guards and capture without a dialog,
|
||||
renders to a private folder under `%TEMP%\OpenNest\Reports\` and opens a modeless
|
||||
viewer window (WebView2's PDF viewer, sharing Help's WebView2 data folder) with
|
||||
**Save As...**, which copies the rendered file to a chosen path, and **Print...**,
|
||||
the WebView2 print dialog. Closing the window deletes its temporary folder; a
|
||||
render failure opens no viewer and leaves no folder. Without the WebView2 Runtime
|
||||
the window still offers Save As.
|
||||
The report renders to a private folder under `%TEMP%\OpenNest\Reports\` and opens
|
||||
a modeless viewer window (WebView2's PDF viewer, sharing Help's WebView2 data
|
||||
folder) with **Save As...**, which copies the rendered file to a chosen path, and
|
||||
**Print...**, the WebView2 print dialog. Save As is the only way to keep the PDF;
|
||||
there is no separate direct-save command. Closing the window deletes its temporary
|
||||
folder; a render failure opens no viewer and leaves no folder. Without the WebView2
|
||||
Runtime the window still offers Save As.
|
||||
|
||||
The same two calls back the command and any future integration:
|
||||
|
||||
@@ -31,7 +31,7 @@ the selected plate, or certify that a layout passed geometry/pre-post checks.
|
||||
|
||||
## Part printouts
|
||||
|
||||
**File -> View Part Printouts...** prints every non-cutoff drawing of the active
|
||||
**File -> Part Printouts...** prints every non-cutoff drawing of the active
|
||||
nest; **View Part Printout...** on the drawing list's right-click menu prints the
|
||||
selected one. Both render to `%TEMP%\OpenNest\Reports\` and open the report viewer,
|
||||
suggesting `<nest-name>.printout.pdf` or `<drawing-name>.printout.pdf`. Each part
|
||||
@@ -191,7 +191,7 @@ concurrent calls cannot lay out text differently from a sequential export.
|
||||
|
||||
## Estimated cut time
|
||||
|
||||
When the caller passes `CutParameters` (the desktop export always does, from the
|
||||
When the caller passes `CutParameters` (the desktop always does, from the
|
||||
settings last used in Calculate Cut Time or the simulator), each plate gets an
|
||||
estimated time per copy from `CutSimulation`, plus clamp-removal minutes, the same
|
||||
as Calculate Cut Time (see [cut-time estimates](cut-time-estimates.md)). The summary
|
||||
@@ -253,10 +253,9 @@ Pixel inspection supplements geometry assertions; it is not a CNC-validation
|
||||
result.
|
||||
|
||||
Windows compilation is not runtime acceptance. `OpenNest.WinForms.Tests/Forms/NestReportExportTests.cs`
|
||||
covers enablement, busy/cancel/failure/success adapter behavior, but it only
|
||||
compiles on Linux. Windows runtime acceptance still owes: exporting a real nest
|
||||
covers enablement, busy/failure/viewer adapter behavior, but it only
|
||||
compiles on Linux. Windows runtime acceptance still owes: reporting a real nest
|
||||
(and the packaged application, so bundled fonts/notices are verified), checking
|
||||
page sizes/labels/copies and embedded fonts with `pdffonts`, a tabbed part with a
|
||||
hole, opening and printing the PDF, and exercising fill/nesting rejection, cancel,
|
||||
overwrite and invalid-path behavior with job state and any existing destination
|
||||
unchanged.
|
||||
hole, saving and printing the PDF from the viewer, and exercising fill/nesting
|
||||
rejection with job state unchanged.
|
||||
@@ -44,9 +44,9 @@ The desktop app can save nests two ways:
|
||||
the record from ordinary browsing but retains every archive; **Deleted nests...**
|
||||
opens an explicit recovery view. Neither action purges data. An old desktop
|
||||
without a revision precondition cannot update or delete on an upgraded server.
|
||||
A separate **File > Export .nest...** command is always available (in both
|
||||
modes) for producing a local file to share or back up. Export does not change
|
||||
the document's file save path or database record association.
|
||||
A separate **File > Save Copy as .nest File...** command is always available
|
||||
(in both modes) for producing a local file to share or back up. The copy does
|
||||
not change the document's file save path or database record association.
|
||||
|
||||
Dragging one or more `.nest` files onto the main window (or onto an open
|
||||
plate) opens them from disk directly, in either mode — this is the only way
|
||||
|
||||
Reference in new issue
Block a user