aj/OpenNest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(benchmark): match drawing identity across materialization boundary in NestValidator

Browse Source 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
aj
2026-09-19 08:29:48 -04:00
co-authored by Claude Sonnet 5
parent 424ff15ebc
commit e0e3b96bed
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
OpenNest.Benchmark/NestValidator.cs
+13 -8
View File
@@ -50,23 +50,28 @@ namespace OpenNest.Benchmark
private static void ValidateQuantities(List<Part> parts, BenchmarkJob job, ValidationResult result)
{
var allowed = job.Requests.ToDictionary(r => r.Drawing.Id, r => r.Quantity);
// Materialized parts reference freshly reconstructed Drawing objects (NestResultMaterializer
// rebuilds them via DrawingJobMapper.CreateDrawing, which sets the materialized Drawing's Name
// to the originating NestJobPart id - a fresh, unrelated Drawing.Id gets auto-generated instead).
// BuildNestJob sets each NestJobPart's id to the original Drawing.Id.ToString(), so that string -
// materialized as BaseDrawing.Name - is the stable identity across the materialization boundary.
var allowed = job.Requests.ToDictionary(r => r.Drawing.Id.ToString(), r => (r.Quantity, r.Drawing.Name));
var placedCounts = parts
.GroupBy(p => p.BaseDrawing.Id)
.GroupBy(p => p.BaseDrawing.Name)
.ToDictionary(g => g.Key, g => g.Count());
foreach (var (drawingId, placed) in placedCounts)
foreach (var (partId, placed) in placedCounts)
{
if (!allowed.TryGetValue(drawingId, out var max))
if (!allowed.TryGetValue(partId, out var requirement))
{
result.Violations.Add($"Placed drawing id={drawingId} which was not requested for this job");
result.Violations.Add($"Placed drawing id={partId} which was not requested for this job");
continue;
}
if (placed > max)
if (placed > requirement.Quantity)
{
var name = parts.First(p => p.BaseDrawing.Id == drawingId).BaseDrawing.Name;
result.Violations.Add($"'{name}': placed {placed} across all plates but only {max} were requested");
result.Violations.Add(
$"'{requirement.Name}': placed {placed} across all plates but only {requirement.Quantity} were requested");
}
}
}