aj/OpenNest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(engine): reject unrepresentable nesting output before geometry checks

Browse Source
This commit is contained in:
aj
2026-09-29 10:47:36 -04:00
parent ac901f7ee9
commit b8bded1b09
6 changed files with 335 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files
OpenNest.Engine.Tests/Jobs/NestLayoutCheckTests.cs
+67 -21
View File
@@ -6,32 +6,78 @@ namespace OpenNest.Engine.Tests.Jobs;
public class NestLayoutCheckTests
{
[Theory]
[InlineData(null, false)]
[InlineData(1, true)]
[InlineData(2, false)]
[InlineData(3, false)]
public void MaxPlatesCountsPhysicalSheetsIncludingEmptyOnes(int? maxPlates, bool exceedsLimit)
{
var stock = new NestPlateStock("sheet", new Size(48, 96));
var job = new NestJob(Array.Empty<NestJobPart>(), new[] { stock }, new NestJobOptions(maxPlates: maxPlates));
var result = new NestJobResult(NestJobStatus.Complete, NestJobStopReason.Completed,
new[]
{
new NestJobPlateResult(7, stock, Array.Empty<NestJobPlacement>()),
new NestJobPlateResult(42, stock, Array.Empty<NestJobPlacement>()),
}, Array.Empty<PartFulfillment>(), Array.Empty<StockUsage>());
var violations = NestLayoutCheck.Violations(job, result);
if (exceedsLimit)
Assert.Contains(violations, v => v.Contains("MaxPlates") && v.Contains("2") && v.Contains("1"));
else
Assert.Empty(violations);
}
[Theory]
[InlineData("ghost", 1, 1, 0)]
[InlineData(null, 1, 1, 0)]
[InlineData("p", double.NaN, 1, 0)]
[InlineData("p", 1, double.PositiveInfinity, 0)]
[InlineData("p", 1, 1, double.NaN)]
public void MalformedPlacementsProduceDiagnosticsRatherThanThrowing(string? partId, double x, double y, double rotation)
{
var stock = new NestPlateStock("sheet", new Size(48, 96));
var job = new NestJob(new[]
{
new NestJobPart("p", PartGeometrySnapshot.FromProgram(TestDrawingFactory.Rectangle()), 1),
}, new[] { stock });
var result = new NestJobResult(NestJobStatus.Complete, NestJobStopReason.Completed,
new[] { new NestJobPlateResult(0, stock, new[] { new NestJobPlacement(partId!, 0, x, y, rotation) }) },
Array.Empty<PartFulfillment>(), Array.Empty<StockUsage>());
var violations = NestLayoutCheck.Violations(job, result);
Assert.NotEmpty(violations);
}
[Fact]
public void TangentDiscsClearAtSafeMarginAcrossRadiiAnglesAndTolerances()
{
var count = 0;
foreach (var radius in new[] { 0.1, 1.0, 10.0 })
foreach (var tolerance in new[] { 0.0, 0.0005, 0.01 })
foreach (var spacing in new[] { 0.0, 0.25 })
{
var program = new Program();
program.MoveTo(radius, 0);
program.Codes.Add(new ArcMove(radius, 0, 0, 0, RotationType.CW));
var geometry = JobPartGeometry.Read(PartGeometrySnapshot.FromProgram(program));
// Two inscribed engine outlines can underestimate true extent by t each.
var distance = 2 * radius + spacing
+ NestTolerances.SafeClearanceMargin(tolerance) - 2 * tolerance;
for (var degrees = 0; degrees < 360; degrees += 15)
{
var angle = degrees * System.Math.PI / 180;
var a = new NestJobPlacement("disc", 0, 0.12345, -0.54321, angle / 3);
var b = new NestJobPlacement("disc", 1, a.X + distance * System.Math.Cos(angle),
a.Y + distance * System.Math.Sin(angle), -angle / 7);
Assert.True(NestLayoutCheck.Clears(geometry, a, geometry, b, spacing));
Assert.True(NestLayoutCheck.Clears(geometry, b, geometry, a, spacing));
count++;
}
}
foreach (var tolerance in new[] { 0.0, 0.0005, 0.01 })
foreach (var spacing in new[] { 0.0, 0.25 })
{
var program = new Program();
program.MoveTo(radius, 0);
program.Codes.Add(new ArcMove(radius, 0, 0, 0, RotationType.CW));
var geometry = JobPartGeometry.Read(PartGeometrySnapshot.FromProgram(program));
// Two inscribed engine outlines can underestimate true extent by t each.
var distance = 2 * radius + spacing
+ NestTolerances.SafeClearanceMargin(tolerance) - 2 * tolerance;
for (var degrees = 0; degrees < 360; degrees += 15)
{
var angle = degrees * System.Math.PI / 180;
var a = new NestJobPlacement("disc", 0, 0.12345, -0.54321, angle / 3);
var b = new NestJobPlacement("disc", 1, a.X + distance * System.Math.Cos(angle),
a.Y + distance * System.Math.Sin(angle), -angle / 7);
Assert.True(NestLayoutCheck.Clears(geometry, a, geometry, b, spacing));
Assert.True(NestLayoutCheck.Clears(geometry, b, geometry, a, spacing));
count++;
}
}
Assert.Equal(432, count);
}