fix: address review findings — input validation, exception handling, cleanup

Add argument validation to EllipseConverter.Convert for tolerance and
semi-axis parameters. Narrow bare catch in Extensions.cs spline method
to log via Debug.WriteLine. Remove unused lineCount variable from
SolidWorksBendDetectorTests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-03-27 15:34:13 -04:00
parent 9b460f77e5
commit a34811bb6d
3 changed files with 8 additions and 2 deletions
@@ -70,7 +70,6 @@ public class SolidWorksBendDetectorTests
// changing the entity count. Verify arcs are present and no
// spurious closing chord exists.
var arcCount = result.Entities.Count(e => e is OpenNest.Geometry.Arc);
var lineCount = result.Entities.Count(e => e is OpenNest.Geometry.Line);
var circleCount = result.Entities.Count(e => e is OpenNest.Geometry.Circle);
Assert.True(arcCount > 0, "Expected arcs from ellipse conversion");