refactor(shapes): generalize OctagonShape to NgonShape

Parameterize side count so users can generate any regular n-gon (n>=3). Width remains the inscribed-circle diameter, preserving n=8 behavior; circumradius derives as Width / (2*cos(pi/n)). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-15 13:42:02 -04:00
parent 6fdf0ad3c5
commit 9b84508ff4
3 changed files with 63 additions and 41 deletions
@@ -0,0 +1,51 @@
+using OpenNest.Shapes;
+
+namespace OpenNest.Tests.Shapes;
+
+public class NgonShapeTests
+{
+    [Fact]
+    public void GetDrawing_Octagon_BoundingBoxFitsWithinExpectedSize()
+    {
+        var shape = new NgonShape { Sides = 8, Width = 20 };
+        var drawing = shape.GetDrawing();
+
+        var bbox = drawing.Program.BoundingBox();
+        // Corner-to-corner is larger than flat-to-flat
+        Assert.True(bbox.Width >= 20 - 0.01);
+        Assert.True(bbox.Length >= 20 - 0.01);
+        // But should not be wildly larger (corner-to-corner ~ width / cos(22.5deg) ~ width * 1.0824)
+        Assert.True(bbox.Width < 22);
+        Assert.True(bbox.Length < 22);
+    }
+
+    [Theory]
+    [InlineData(3)]
+    [InlineData(4)]
+    [InlineData(5)]
+    [InlineData(6)]
+    [InlineData(8)]
+    [InlineData(12)]
+    public void GetDrawing_HasOneLinearMovePerSide(int sides)
+    {
+        var shape = new NgonShape { Sides = sides, Width = 20 };
+        var drawing = shape.GetDrawing();
+
+        var moves = drawing.Program.Codes
+            .OfType<OpenNest.CNC.LinearMove>()
+            .Count();
+        Assert.Equal(sides, moves);
+    }
+
+    [Fact]
+    public void GetDrawing_ClampsSidesBelowThreeToTriangle()
+    {
+        var shape = new NgonShape { Sides = 2, Width = 20 };
+        var drawing = shape.GetDrawing();
+
+        var moves = drawing.Program.Codes
+            .OfType<OpenNest.CNC.LinearMove>()
+            .Count();
+        Assert.Equal(3, moves);
+    }
+}
@@ -1,34 +0,0 @@
-using OpenNest.Shapes;
-
-namespace OpenNest.Tests.Shapes;
-
-public class OctagonShapeTests
-{
-    [Fact]
-    public void GetDrawing_BoundingBoxFitsWithinExpectedSize()
-    {
-        var shape = new OctagonShape { Width = 20 };
-        var drawing = shape.GetDrawing();
-
-        var bbox = drawing.Program.BoundingBox();
-        // Corner-to-corner is larger than flat-to-flat
-        Assert.True(bbox.Width >= 20 - 0.01);
-        Assert.True(bbox.Length >= 20 - 0.01);
-        // But should not be wildly larger (corner-to-corner ~ width / cos(22.5deg) ~ width * 1.0824)
-        Assert.True(bbox.Width < 22);
-        Assert.True(bbox.Length < 22);
-    }
-
-    [Fact]
-    public void GetDrawing_HasEightEdges()
-    {
-        var shape = new OctagonShape { Width = 20 };
-        var drawing = shape.GetDrawing();
-
-        // An octagon program should have 8 linear moves (one per edge)
-        var moves = drawing.Program.Codes
-            .OfType<OpenNest.CNC.LinearMove>()
-            .Count();
-        Assert.Equal(8, moves);
-    }
-}