From 90a6d9e4d26e30070e08916cd39a72b8414fa3c6 Mon Sep 17 00:00:00 2001 From: AJ Isaacs Date: Fri, 16 Oct 2026 13:15:48 -0400 Subject: [PATCH] refactor(core): drop System.Drawing.Common and fix CutParameters namespace Core only uses System.Drawing.Color, which ships in the shared framework, so the System.Drawing.Common package (Windows-only beyond primitives) was an unneeded dependency of the cross-platform domain library. The desktop app keeps its own reference. CutParameters lives in OpenNest.Core but declared namespace OpenNest.Api, forcing Core and desktop files to import the Api namespace for a Core type. Co-Authored-By: Claude Opus 5.5 --- OpenNest.Core/CutParameters.cs | 2 +- OpenNest.Core/OpenNest.Core.csproj | 1 - OpenNest.Core/Timing.cs | 1 - OpenNest.Tests/Api/CutParametersTests.cs | 2 -- OpenNest.Tests/TimingTests.cs | 1 - OpenNest/Forms/CutParametersForm.cs | 1 - OpenNest/Forms/EditNestForm.cs | 1 - OpenNest/Forms/TimingForm.cs | 1 - 8 files changed, 1 insertion(+), 9 deletions(-) diff --git a/OpenNest.Core/CutParameters.cs b/OpenNest.Core/CutParameters.cs index a3c5ff41..8e538ac4 100644 --- a/OpenNest.Core/CutParameters.cs +++ b/OpenNest.Core/CutParameters.cs @@ -1,6 +1,6 @@ using System; -namespace OpenNest.Api; +namespace OpenNest; public class CutParameters { diff --git a/OpenNest.Core/OpenNest.Core.csproj b/OpenNest.Core/OpenNest.Core.csproj index 45d022cc..74047974 100644 --- a/OpenNest.Core/OpenNest.Core.csproj +++ b/OpenNest.Core/OpenNest.Core.csproj @@ -10,6 +10,5 @@ - diff --git a/OpenNest.Core/Timing.cs b/OpenNest.Core/Timing.cs index 338bde9c..0b0f14c9 100644 --- a/OpenNest.Core/Timing.cs +++ b/OpenNest.Core/Timing.cs @@ -1,6 +1,5 @@ using System; using System.Linq; -using OpenNest.Api; using OpenNest.CNC; using OpenNest.Converters; using OpenNest.Geometry; diff --git a/OpenNest.Tests/Api/CutParametersTests.cs b/OpenNest.Tests/Api/CutParametersTests.cs index 9f498734..e79eed2f 100644 --- a/OpenNest.Tests/Api/CutParametersTests.cs +++ b/OpenNest.Tests/Api/CutParametersTests.cs @@ -1,5 +1,3 @@ -using OpenNest.Api; - namespace OpenNest.Tests.Api; public class CutParametersTests diff --git a/OpenNest.Tests/TimingTests.cs b/OpenNest.Tests/TimingTests.cs index f9f65285..eba62411 100644 --- a/OpenNest.Tests/TimingTests.cs +++ b/OpenNest.Tests/TimingTests.cs @@ -1,4 +1,3 @@ -using OpenNest.Api; using OpenNest.Geometry; namespace OpenNest.Tests; diff --git a/OpenNest/Forms/CutParametersForm.cs b/OpenNest/Forms/CutParametersForm.cs index 6385437f..b049262d 100644 --- a/OpenNest/Forms/CutParametersForm.cs +++ b/OpenNest/Forms/CutParametersForm.cs @@ -1,6 +1,5 @@ using System; using System.Windows.Forms; -using OpenNest.Api; namespace OpenNest.Forms { diff --git a/OpenNest/Forms/EditNestForm.cs b/OpenNest/Forms/EditNestForm.cs index bb796a4a..0ec6829e 100644 --- a/OpenNest/Forms/EditNestForm.cs +++ b/OpenNest/Forms/EditNestForm.cs @@ -6,7 +6,6 @@ using System.IO; using System.Linq; using System.Windows.Forms; using OpenNest.Actions; -using OpenNest.Api; using OpenNest.CNC.CuttingStrategy; using OpenNest.Collections; using OpenNest.Controls; diff --git a/OpenNest/Forms/TimingForm.cs b/OpenNest/Forms/TimingForm.cs index 5e45902e..17f09baa 100644 --- a/OpenNest/Forms/TimingForm.cs +++ b/OpenNest/Forms/TimingForm.cs @@ -1,6 +1,5 @@ using System; using System.Windows.Forms; -using OpenNest.Api; namespace OpenNest.Forms {