aj/OpenNest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

build(release): package built-in engines instead of external plug-ins

Browse Source 
Rectangles and Irregular now ship inside OpenNest.Engine.dll, so the Windows
package no longer fetches, tests and bundles OpenNest-Engines at a pinned
commit. Removes scripts/external-engines.json and the Engines/ folder,
manifest and license from the package; build-info.json drops enginesCommit.

ReleaseSmoke now checks the packaged registry: every built-in engine must
instantiate from the packaged OpenNest.Engine.dll, the Opus55NestingEngine
name must resolve to Irregular, and an unknown name must be rejected. Linux
check against a published OpenNest.Engine: pass case exit 0; missing engine
DLL exit 1. Full Windows packaging still needs the Windows runner.
This commit is contained in:
aj
2026-09-29 21:18:53 -04:00
parent b688ce896f
commit 7f648e6400
3 changed files with 31 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/ReleaseSmoke/Program.cs
+27 -13
View File
@@ -1,6 +1,5 @@
using System.Reflection;
using System.Runtime.Loader;
using System.Text.Json;
try
{
@@ -15,21 +14,36 @@ try
return File.Exists(path) ? AssemblyLoadContext.Default.LoadFromAssemblyPath(path) : null;
};
var engineAssembly = Assembly.LoadFrom(Path.Combine(package, "OpenNest.Engine.dll"));
var engineAssemblyPath = Path.Combine(package, "OpenNest.Engine.dll");
var engineAssembly = Assembly.LoadFrom(engineAssemblyPath);
var registry = engineAssembly.GetType("OpenNest.Engine.Jobs.NestingEngineRegistry", true)!;
var engineDirectory = Path.Combine(package, "Engines");
registry.GetMethod("LoadPlugins")!.Invoke(null, [engineDirectory]);
using var manifest = JsonDocument.Parse(File.ReadAllText(Path.Combine(engineDirectory, "manifest.json")));
foreach (var entry in manifest.RootElement.GetProperty("engines").EnumerateArray())
var create = registry.GetMethod("Create")!;
// Every built-in engine the desktop offers must instantiate from the packaged assembly.
string[] expected = ["Rectangles", "Irregular", "StockLadder", "Default", "Strip", "Vertical Remnant", "Horizontal Remnant"];
foreach (var name in expected)
{
var name = entry.GetProperty("registryName").GetString()!;
var expected = Path.Combine(engineDirectory, entry.GetProperty("project").GetString() + ".dll");
if (!File.Exists(expected))
throw new FileNotFoundException("Required engine missing", expected);
var engine = registry.GetMethod("Create")!.Invoke(null, [name])!;
if (!string.Equals(engine.GetType().Assembly.Location, expected, StringComparison.OrdinalIgnoreCase))
var engine = create.Invoke(null, [name])!;
if (!string.Equals(engine.GetType().Assembly.Location, engineAssemblyPath, StringComparison.OrdinalIgnoreCase))
throw new InvalidOperationException($"Engine {name} was not loaded from the release package.");
Console.WriteLine($"PASS: {name} loaded and instantiated from {expected}");
Console.WriteLine($"PASS: {name} instantiated from {engineAssemblyPath}");
}
// A selection saved before the engines were renamed must still resolve.
var resolved = registry.GetMethod("ResolveName")!.Invoke(null, ["Opus55NestingEngine"]);
if (!Equals(resolved, "Irregular"))
throw new InvalidOperationException($"Legacy selection Opus55NestingEngine resolved to '{resolved}', expected Irregular.");
Console.WriteLine("PASS: legacy selection Opus55NestingEngine resolves to Irregular");
// Failure case: an unknown engine must be rejected, so a broken registry cannot pass silently.
try
{
create.Invoke(null, ["ReleaseSmokeMissingEngine"]);
throw new InvalidOperationException("Unknown engine name was accepted.");
}
catch (TargetInvocationException exception) when (exception.InnerException is NotSupportedException)
{
Console.WriteLine("PASS: unknown engine name rejected");
}
return 0;
}