aj/OpenNest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(engine): stop PairFiller toggling the global fill-strategy registry

Browse Source 
PairFiller.EvaluateCandidates wrapped its candidate loop in
FillStrategyRegistry.SetEnabled(...) and reset it with SetEnabled(null)
afterwards. Nothing inside that window re-enters the strategy pipeline
(EvaluateCandidate and FillRemnantBox only use FillLinear), so the
restriction had no effect on the running solve. It did mutate process-global
state: concurrent solves (e.g. benchmark --parallel) could observe the
narrowed strategy list, and the reset cleared any filter set elsewhere.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
aj
2026-09-20 22:20:30 -04:00
co-authored by Claude Sonnet 5
parent 5061b41a5d
commit 451876c02f
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
OpenNest.Engine/Fill/PairFiller.cs
-5
View File
@@ -97,7 +97,6 @@ namespace OpenNest.Engine.Fill
var partBox = drawing.Program.BoundingBox(); var partBox = drawing.Program.BoundingBox();
var partArea = System.Math.Max(partBox.Width * partBox.Length, 1); var partArea = System.Math.Max(partBox.Width * partBox.Length, 1);
FillStrategyRegistry.SetEnabled("Pairs", "RectBestFit", "Extents", "Linear");
try try
{ {
for (var batchStart = 0; batchStart < candidates.Count; batchStart += batchSize) for (var batchStart = 0; batchStart < candidates.Count; batchStart += batchSize)
@@ -165,10 +164,6 @@ namespace OpenNest.Engine.Fill
{ {
Debug.WriteLine("[PairFiller] Cancelled mid-phase, using results so far"); Debug.WriteLine("[PairFiller] Cancelled mid-phase, using results so far");
} }
finally
{
FillStrategyRegistry.SetEnabled(null);
}
Debug.WriteLine($"[PairFiller] Best pair result: {best?.Count ?? 0} parts"); Debug.WriteLine($"[PairFiller] Best pair result: {best?.Count ?? 0} parts");
return best ?? new List<Part>(); return best ?? new List<Part>();